Skip to content

chore: bytecode strict typing#18165

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
mainfrom
chore/bytecode-strict-typing
May 22, 2026
Merged

chore: bytecode strict typing#18165
gh-worker-dd-mergequeue-cf854d[bot] merged 5 commits into
mainfrom
chore/bytecode-strict-typing

Conversation

@P403n1x87
Copy link
Copy Markdown
Contributor

Description

We enable strict type checking for bytecode handling modules.

We enable strict type checking for bytecode handling modules.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label May 19, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da Bot commented May 19, 2026

Codeowners resolved as

ddtrace/debugging/_expressions.py                                       @DataDog/debugger-python
ddtrace/internal/assembly.py                                            @DataDog/apm-core-python
ddtrace/internal/bytecode_injection/__init__.py                         @DataDog/apm-core-python
ddtrace/internal/wrapping/__init__.py                                   @DataDog/apm-core-python
ddtrace/internal/wrapping/asyncs.py                                     @DataDog/apm-core-python
ddtrace/internal/wrapping/context.py                                    @DataDog/apm-core-python
ddtrace/internal/wrapping/generators.py                                 @DataDog/apm-core-python
mypy.ini                                                                @DataDog/python-guild @DataDog/apm-core-python
pyproject.toml                                                          @DataDog/python-guild

@datadog-prod-us1-3
Copy link
Copy Markdown

datadog-prod-us1-3 Bot commented May 19, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 8 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741238-d2b8243-manylinux2014_x86_64, 1]   View in Datadog   GitLab

🔄 Retry job. This looks flaky and may succeed on retry. Startup probe failed: HTTP probe failed with statuscode: 503

DataDog/apm-reliability/dd-trace-py | build linux serverless: [amd64, cp315-cp315, v113741491-d2b8243-musllinux_1_2_x86_64, 1]   View in Datadog   GitLab

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. NotImplementedError: This version of CPython is not supported yet

DataDog/apm-reliability/dd-trace-py | build linux serverless: [arm64, cp315-cp315, v113741357-d2b8243-manylinux2014_aarch64, 1]   View in Datadog   GitLab

🛟 This job is unlikely to succeed on retry. Please review your pipeline configuration. Dependency download failed due to missing or unavailable package 'wrapt==2.2.1'.

View all 8 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 3c244db | Docs | Datadog PR Page | Give us feedback!

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 19, 2026

Benchmarks

Benchmark execution time: 2026-05-22 15:27:12

Comparing candidate commit 3c244db in PR branch chore/bytecode-strict-typing with baseline commit 5827540 in branch main.

Found 0 performance improvements and 6 performance regressions! Performance is the same for 614 metrics, 10 unstable metrics.

scenario:iast_aspects-re_expand_aspect

  • 🟥 execution_time [+267.891µs; +314.451µs] or [+7.633%; +8.960%]

scenario:iastaspects-ljust_aspect

  • 🟥 execution_time [+81.610µs; +90.668µs] or [+16.398%; +18.218%]

scenario:iastaspects-stringio_aspect

  • 🟥 execution_time [+631.681µs; +684.130µs] or [+16.299%; +17.652%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+103.476µs; +111.780µs] or [+24.365%; +26.320%]

scenario:span-start

  • 🟥 execution_time [+1.478ms; +1.638ms] or [+9.438%; +10.462%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+242.991ns; +274.154ns] or [+11.237%; +12.678%]

@P403n1x87 P403n1x87 marked this pull request as ready for review May 19, 2026 15:19
@P403n1x87 P403n1x87 requested review from a team as code owners May 19, 2026 15:19
@P403n1x87 P403n1x87 requested review from Yun-Kim and juanjux May 19, 2026 15:19
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit b26f246 into main May 22, 2026
1220 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the chore/bytecode-strict-typing branch May 22, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants